-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ccs 3510 back button bug fix #477
Conversation
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
============================================
- Coverage 58.55% 58.08% -0.47%
- Complexity 495 499 +4
============================================
Files 126 128 +2
Lines 4034 4056 +22
Branches 553 576 +23
============================================
- Hits 2362 2356 -6
- Misses 1559 1585 +26
- Partials 113 115 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, @xdavidson can you test it before we approve?
I tested this branch locally. The backbutton works when I go from product details to product Listing. |
We now have the ability to press the back button from Product Details to return to Product Listings
productDetails.tsx
andproductListing.tsx
so they are now functional componentsProductContext
soproductDetails.tsx
andproductListing.tsx
can access all product info