Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccs 3510 back button bug fix #477

Merged
merged 15 commits into from
Dec 1, 2020
Merged

Conversation

grantsydney
Copy link
Contributor

We now have the ability to press the back button from Product Details to return to Product Listings

  • refactored productDetails.tsx and productListing.tsx so they are now functional components
  • created ProductContext so productDetails.tsx and productListing.tsx can access all product info

@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #477 (3b7010e) into master (4e8391e) will decrease coverage by 0.46%.
The diff coverage is 52.96%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #477      +/-   ##
============================================
- Coverage     58.55%   58.08%   -0.47%     
- Complexity      495      499       +4     
============================================
  Files           126      128       +2     
  Lines          4034     4056      +22     
  Branches        553      576      +23     
============================================
- Hits           2362     2356       -6     
- Misses         1559     1585      +26     
- Partials        113      115       +2     
Flag Coverage Δ Complexity Δ
java 58.08% <52.96%> (-0.47%) 0.00 <13.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...edhat/pantheon/asciidoctor/AsciidoctorService.java 3.73% <0.00%> (+0.02%) 3.00 <0.00> (ø)
...ctor/extension/MetadataExtractorTreeProcessor.java 80.39% <ø> (-0.38%) 17.00 <0.00> (ø)
...n/servlet/assembly/AssemblyVariantJsonServlet.java 67.69% <0.00%> (-0.53%) 7.00 <0.00> (ø)
...at/pantheon/servlet/module/VariantJsonServlet.java 67.34% <0.00%> (-0.70%) 3.00 <0.00> (ø)
...om/redhat/pantheon/servlet/util/ServletHelper.java 55.40% <ø> (ø) 17.00 <0.00> (ø)
pantheon-bundle/frontend/src/app/versions.tsx 42.04% <14.28%> (-1.35%) 0.00 <0.00> (ø)
...undle/frontend/src/app/contexts/ProductContext.tsx 18.75% <18.75%> (ø) 0.00 <0.00> (?)
pantheon-bundle/frontend/src/app/product.tsx 44.31% <28.57%> (-8.07%) 0.00 <0.00> (ø)
...antheon-bundle/frontend/src/app/productDetails.tsx 47.12% <48.64%> (+6.16%) 0.00 <0.00> (ø)
...t/pantheon/servlet/module/ModuleVersionUpload.java 60.00% <50.00%> (-25.94%) 5.00 <2.00> (-4.00)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e8391e...61b0a24. Read the comment docs.

Copy link
Contributor

@wesruv wesruv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me, @xdavidson can you test it before we approve?

@xdavidson
Copy link
Collaborator

I tested this branch locally. The backbutton works when I go from product details to product Listing.

@grantsydney grantsydney merged commit 1383a6f into master Dec 1, 2020
@xdavidson xdavidson deleted the CCS-3510-back-button-bug-fix branch December 17, 2020 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants