-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CCS-4249 sso enhancement #542
CCS-4249 sso enhancement #542
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing major. can't wait to see this released!
// const wrapper = mount(<Router><User {...mockStateUser} /></Router>) | ||
// const navLinks = wrapper.find(Link) | ||
// expect(navLinks.exists()).toBe(true) | ||
// }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove these code block comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@Component( | ||
service = Servlet.class, | ||
property = { | ||
"sling.servlet.methods={GET, POST}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: there is a @SlingServlet
(or something like that) annotation that makes this a bit cleaner.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
according to this documentation, osgi annotation is preferred.
The @SlingServlet annotation (evaluated by maven-scr-plugin, use only if you can neither use 1. nor 2.)
https://sling.apache.org/documentation/the-sling-engine/servlets.html
Codecov Report
@@ Coverage Diff @@
## master #542 +/- ##
============================================
- Coverage 55.93% 55.63% -0.31%
Complexity 513 513
============================================
Files 139 141 +2
Lines 4389 4404 +15
Branches 610 614 +4
============================================
- Hits 2455 2450 -5
- Misses 1811 1831 +20
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This PR introduces the following changes: