馃敡 Refactor AWS hourly images to get cloud access images as well #7
Comments
major
added a commit
that referenced
this issue
Oct 6, 2022
Update pytest fixtures to include cloud access billing codes and use those fixtures consistently. Add the billing codes to config and use the constants consistently. Split out the actual AWS describe_image call into its own function for easier mocking and testing. Add an argument to get_aws_images that specifies which image types to filter for with hourly as the default. Fixes: #7 Signed-off-by: Major Hayden <major@redhat.com>
major
added a commit
that referenced
this issue
Oct 7, 2022
Update pytest fixtures to include cloud access billing codes and use those fixtures consistently. Add the billing codes to config and use the constants consistently. Split out the actual AWS describe_image call into its own function for easier mocking and testing. Add an argument to get_aws_images that specifies which image types to filter for with hourly as the default. Fixes: #7 Signed-off-by: Major Hayden <major@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We have
get_aws_hourly_images()now, but it pulls a full list of images and filters out the cloud access images. We should probably refactor this to make one function that does the API call and then two separate functions that filter the results. We will need the list of cloud access instances eventually.The text was updated successfully, but these errors were encountered: