Refactor AWS images for hourly/cloudaccess #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like the changes. About your concern regarding the individual commits: I think the readability is fine but we might want to consider squashing the "fix" commits. e.g. I don't think splitting the commits is necessary though as they do follow a logical structure that makes sense. |
F-X64
approved these changes
Oct 7, 2022
|
|
||
|
|
||
| def get_aws_all_hourly_images() -> dict[str, list[str]]: | ||
| def get_aws_all_images(image_type: str = "hourly") -> dict[str, list[dict[str, str]]]: |
There was a problem hiding this comment.
Thanks for this. Wanted to implement it myself so this save me loads of time ;)
There was a problem hiding this comment.
Hah yeah, I wasn't thinking through it terribly deeply when I wrote it the first time. 🤦🏻♂️
|
Looks like I have a conflict with that other PR. I'll resolve it right quick. |
Update pytest fixtures to include cloud access billing codes and use those fixtures consistently. Add the billing codes to config and use the constants consistently. Split out the actual AWS describe_image call into its own function for easier mocking and testing. Add an argument to get_aws_images that specifies which image types to filter for with hourly as the default. Fixes: #7 Signed-off-by: Major Hayden <major@redhat.com>
major
force-pushed
the
update-tests-use-common-fixtures
branch
from
c7f7389
to
466928b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update pytest fixtures to include cloud access billing codes and use
those fixtures consistently. Add the billing codes to config and use the
constants consistently.
Split out the actual AWS describe_image call into its own function for
easier mocking and testing. Add an argument to get_aws_images that
specifies which image types to filter for with hourly as the default.
Fixes: #7