Fix t/08_readmember_record_sep.t for Win32 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was being skipped in Win32 because of test failures. The test failures were caused by A::Z reading/writing members in binary mode, i.e. without any newline conversion. This has to be taken into account in the test, by: - Converting "\n" into "\r\n" in the data file prior to writing to the zip file, if running in Win32. - Converting "\n" of the expected strings returned by getline() into "\r\n" before checking, if running in Win32. These changes were made to the test file and all tests pass on Win32. On other platforms the changes have no effect, and should pass the tests also.
redhotpenguin
added a commit
that referenced
this pull request
Aug 26, 2015
Fix t/08_readmember_record_sep.t for Win32
|
Thanks, deployed with 1.50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was being skipped in Win32 because of test failures.
The test failures were caused by A::Z reading/writing members in binary
mode, i.e. without any newline conversion. This has to be taken into
account in the test, by:
zip file, if running in Win32.
"\r\n" before checking, if running in Win32.
These changes were made to the test file and all tests pass on Win32.
On other platforms the changes have no effect, and should pass the tests
also.