New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix t/08_readmember_record_sep.t for Win32 #19

Merged
merged 3 commits into from Aug 26, 2015

Conversation

Projects
None yet
2 participants
@pauloscustodio
Contributor

pauloscustodio commented Aug 24, 2015

The test was being skipped in Win32 because of test failures.

The test failures were caused by A::Z reading/writing members in binary
mode, i.e. without any newline conversion. This has to be taken into
account in the test, by:

  • Converting "\n" into "\r\n" in the data file prior to writing to the
    zip file, if running in Win32.
  • Converting "\n" of the expected strings returned by getline() into
    "\r\n" before checking, if running in Win32.

These changes were made to the test file and all tests pass on Win32.
On other platforms the changes have no effect, and should pass the tests
also.

pauloscustodio added some commits Aug 24, 2015

Fix t/08_readmember_record_sep.t for Win32
The test was being skipped in Win32 because of test failures.

The test failures were caused by A::Z reading/writing members in binary
mode, i.e. without any newline conversion. This has to be taken into
account in the test, by:
- Converting "\n" into "\r\n" in the data file prior to writing to the
  zip file, if running in Win32.
- Converting "\n" of the expected strings returned by getline() into
  "\r\n" before checking, if running in Win32.

These changes were made to the test file and all tests pass on Win32.
On other platforms the changes have no effect, and should pass the tests
also.

redhotpenguin added a commit that referenced this pull request Aug 26, 2015

Merge pull request #19 from pauloscustodio/master
Fix t/08_readmember_record_sep.t for Win32

@redhotpenguin redhotpenguin merged commit aa0c694 into redhotpenguin:master Aug 26, 2015

@redhotpenguin

This comment has been minimized.

Show comment
Hide comment
@redhotpenguin

redhotpenguin Aug 26, 2015

Owner

Thanks, deployed with 1.50

Owner

redhotpenguin commented Aug 26, 2015

Thanks, deployed with 1.50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment