Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix a dedicated method for watch to be the same manner as the multi method #342

Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: fix a dedicated method for watch to be the same manner as the multi method #342

merged 1 commit into from
Mar 14, 2024

Conversation

supercaracal
Copy link
Member

@supercaracal supercaracal changed the title fix: fix a dedicated method for watch to be same manner as the multi method fix: fix a dedicated method for watch to be the same manner as the multi method Mar 14, 2024
@supercaracal supercaracal marked this pull request as ready for review March 14, 2024 05:12
@supercaracal supercaracal merged commit 23fd884 into redis-rb:master Mar 14, 2024
25 checks passed
@supercaracal supercaracal deleted the fix-watch branch March 14, 2024 05:12
@KJTsanaktsidis
Copy link
Contributor

Ah, sorry, this was a rebase mistake in my part - I actually had deleted the code you fixed in this PR on the branch I was testing, which is why I didn't notice this.

#340 is what I replaced the WATCH command handling with if you're happy to have another look at that approach. I made the watch method private so that it didn't add to the redis-cluster-client API in a way you weren't happy with, but could still be called from redis-rb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@supercaracal @KJTsanaktsidis