Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expiration time integer types inconsistent with SetExpiry #1150

Closed
ahmadbky opened this issue Apr 15, 2024 · 2 comments · Fixed by #1152
Closed

Expiration time integer types inconsistent with SetExpiry #1150

ahmadbky opened this issue Apr 15, 2024 · 2 comments · Fixed by #1152

Comments

@ahmadbky
Copy link
Contributor

ahmadbky commented Apr 15, 2024 •
edited
Loading

Hello, I just noticed that the integer types for the expiration times were not updated for the SetExpiry enum, which still relies on usizes (see #589).

I believe it needs an update too, but I can't tell if these can accept negative values or not.

Thanks 😄
@jaymell
Copy link
Contributor

jaymell commented Apr 17, 2024

None of these will be negative, so changing them to u64 is appropriate I think. Wanna open a PR?

@ahmadbky
Copy link
Contributor Author

Yes no problem, I can do it.

ahmadbky added a commit to ahmadbky/redis-rs that referenced this issue Apr 17, 2024
@ahmadbky
fix redis-rs#1150: change int types for expiry to u64
e6d27a0
@ahmadbky ahmadbky mentioned this issue Apr 17, 2024
Merged
nihohit pushed a commit that referenced this issue Apr 19, 2024
@ahmadbky @nihohit
fix #1150: change int types for expiry to u64
5b80901
barshaul pushed a commit to barshaul/redis-rs that referenced this issue Jul 11, 2024
Node: added zrank command. (redis-rs#1150)
0cb2622 
Node: added zrank and zrankWithScore commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #1150: change int types for expiry to u64 ahmadbky/redis-rs
2 participants
@jaymell @ahmadbky