Allowing the requirement of a tcp timeout when using sentinel as well as when using redis client directly

[jrylander]

The sentinel client is using get_multiplexed_async_connection which uses long timeout. It would be useful for us to have the connection timeouts being configurable when using redis via sentinels as well as when accessing a redis server directly.

Do you think is it feasible to have timeout as an option in the sentinel client and use that when creating connections?

[nihohit]

I don't think any of the maintainers has time to implement this right now, but this should be pretty easy to implement if you want to contribute it. Just please be aware of #1147 (comment) - that is, don't add a '_with_timeouts' function, like we've used in the past, but add a '_with_config' function, so that we won't have an explosion of options and matching functions.

…

On Wed, 24 Apr 2024, 12:23 Johan Rylander, ***@***.***> wrote: The sentinel client is using get_multiplexed_async_connection which uses long timeout. It would be useful for us to have the connection timeouts being configurable when using redis via sentinels as well as when accessing a redis server directly. Do you think is it feasible to have timeout as an option in the sentinel client and use that when creating connections? — Reply to this email directly, view it on GitHub <#1162>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABDEBBVBDETMCQLSVT55ABDY652X7AVCNFSM6AAAAABGWRD7GWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI3DAOBSGY2DKMI> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[jrylander]

Tnx. I will give it a go

[jrylander]

I put together #1167

I am not sure my code is up to snuff for this project though but hope it is useful.

[nihohit]

fixed in #1167