Timeouts for redis client gotten via sentinel #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihohit
reviewed
May 1, 2024
|
Is this closer to your thinking? I am also guessing I should squash commits, right? |
nihohit
approved these changes
May 17, 2024
| docsrs, | ||
| doc(cfg(any(feature = "tokio-comp", feature = "async-std-comp"))) | ||
| )] | ||
| pub async fn get_multiplexed_async_connection_with_config( |
There was a problem hiding this comment.
get_multiplexed_async_connection_with_timeouts should call this
There was a problem hiding this comment.
jrylander
force-pushed
the
sentinel-timeout
branch
from
24b0f5c
to
b90afdf
Compare
|
@jrylander looks like the change has some issues. Do you need help fixing this? |
|
Ahhrg, my bad. I was on a clean computer and could not run tests. I am sorry! |
jrylander
force-pushed
the
sentinel-timeout
branch
from
0186350
to
d2b6c17
Compare
nihohit
approved these changes
May 23, 2024
jrylander
force-pushed
the
sentinel-timeout
branch
from
d2b6c17
to
5a95822
Compare
|
Ran cargo fmt --all |
nihohit
added a commit
to nihohit/redis-rs
that referenced
this pull request
Jun 6, 2024
They're replaced with a constructor that uses a shared config type after redis-rs#1167
nihohit
added a commit
to nihohit/redis-rs
that referenced
this pull request
Jun 7, 2024
They're replaced with a constructor that uses a shared config type after redis-rs#1167
nihohit
added a commit
to nihohit/redis-rs
that referenced
this pull request
Jun 11, 2024
They're replaced with a constructor that uses a shared config type after redis-rs#1167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a redis::sentinel::Sentinel::SentinelClient::get_async_connection_with_config that accepts timeouts
I have added just a happy test for calling with long timeouts. I am not versed enough to add a test for actual timeouts but am not sure it is needed since it just ships the parameters on to redis client.