Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to std::future::Future #231

Closed
wants to merge 2 commits into from
Closed

Conversation

Marwes
Copy link
Collaborator

@Marwes Marwes commented Aug 20, 2019

Can't be merged yet as it depends on async/await being stabilized. Also has one test disabled as https://github.com/facebookincubator/rust-partial-io does not work with tokio-io 0.2.

  • Update partial-io and fix test
  • Don't depend on the whole of tokio
  • Wait for async/await

Closes #184

@badboy
Copy link
Collaborator

badboy commented Aug 24, 2019

Hey, thanks for all that work. Indeed, we need to wait for the stabilization, but happy to start reviewing this (and #232).

Do you think we could extract the 2018 edition fixes and land them up front? That would make it easier to also merge other things if they come in already.

@magnet
Copy link

magnet commented Oct 10, 2019

Hi, std futures are already stabilized, and async/await stabilization is coming in a month. Several crates in the async/tokio ecosystem have published alpha versions on async/await (e.g hyper, mysql_async, etc) so that we can test them. Would you consider doing the same?

@Marwes
Copy link
Collaborator Author

Marwes commented Oct 10, 2019

I think we should jump directly to #232 which requires async await as that improves the API in several ways. I don\t feel like it is ready just yet though as it has a disabled test and some awkward warts which aren't to difficult to fix when I get the time for it (give it a week or two).

@Marwes Marwes closed this Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Futures 0.3 support
3 participants