Allow passing routing information to cluster. #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihohit
force-pushed
the
send-route
branch
5 times, most recently
from
4947655
to
ae89b1d
Compare
This was referenced Jul 31, 2023
nihohit
force-pushed
the
send-route
branch
2 times, most recently
from
98356a0
to
28c07d1
Compare
|
@jaymell rebased |
|
Thanks for the PR! Looking beautiful so far. |
jaymell
reviewed
Sep 17, 2023
This will allow users to implement their own Routables, and find their own routing.
Co-authored-by: James Lucas <jaymell@users.noreply.github.com>
jaymell
reviewed
Sep 18, 2023
jaymell
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based over #900 .
This change allows the user to specify routing information for commands. This is especially helpful for commands that don't have an explicit request policy, such as BGSAVE, and so are sent to a random node.