Execute multi-node requests using try_request. #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nihohit
force-pushed
the
try-request-multi-node
branch
from
36c605b
to
2a2d51f
Compare
nihohit
force-pushed
the
try-request-multi-node
branch
from
2a2d51f
to
4d03be4
Compare
nihohit
force-pushed
the
try-request-multi-node
branch
from
c2ac88e
to
ee01ea2
Compare
This means multi node operations now get error handling, and can trigger MOVED, etc. Additionally, func was removed from CmdArg::Cmd/Pipeline. This removes the need to allocate a box on every request, and slightly reduces code complexity.
nihohit
force-pushed
the
try-request-multi-node
branch
from
ee01ea2
to
2829aef
Compare
|
@jaymell rebased |
barshaul
pushed a commit
to barshaul/redis-rs
that referenced
this pull request
Jul 11, 2024
* Update commandmanager to remove optional<route> argument Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Java: Add GET & SET commands Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Move IT tests to SharedCommandTests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Spotless Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add nonnull check to API Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Fix from merge Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Update handleRedisResponse Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Use @timeout annotation Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove extra @nonnull annotations Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Merge main Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add NonNull Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add back IT tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Remove extra tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Add DELME tests Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> * Minor: clean tests; throw exception Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com> --------- Signed-off-by: Andrew Carbonetto <andrew.carbonetto@improving.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebased over #899 .
This means multi node operations now get error handling, and can trigger
MOVED, etc.
Additionally, func was removed from CmdArg::Cmd/Pipeline. This removes
the need to allocate a box on every request, and slightly reduces code
complexity.