support the same values for domain as rails' session stores usually do #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* needed to change the tests based on test in rails, so the options for the session store could be changed per test
|
❤️ 👍 for this. |
|
Should note that the |
|
any plan to merge this? |
|
Looks good to me. Merged! |
|
Can we get a patch version bump for this? It's not too big of a deal for me to point to master in my Gemfile, but it has been 7 months :-) |
|
Done. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses #1 and redis-store/redis-store#218, redis-store/redis-store#108
I also needed to change the tests based on test in rails, so the options for the session store could be changed per test.