Fixes #189 #190
Merged
Fixes #189 #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll double check that and the failing CI too. |
This is actually a combo, because it fixes the bug and implicitly adds the possibility to set global options which apply to all Redis::Store instances when multiple hosts are set.
|
@jodosha you were right of course defaults are not required, I removed them and squashed my commits. |
|
This will fix #37 as well |
|
An attempt to fix this issue was made here too: #169 but that implementation doesn't to take into account the connection string format, not the hash format. |
|
Another attempt to fix this issue was made here #172 with hash key based approach I personally dislike. |
|
@freegenie After I merged this, master build is broken, would you please take care of this? |
|
@jodosha sure |
benilovj
added a commit
to alphagov/support
that referenced
this pull request
Jan 2, 2014
Before this change, this app was running with a patched version of the redis-activesupport gem which fixed a pretty nasty bug ( redis-store/redis-store#166). This bug was fixed upstream (redis-store/redis-store#190) and released with redis-activesupport 3.2.4 so we don't need to maintain a separate branch any more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is actually a combo, because it fixes the bug and implicitly
adds the possibility to set global options which apply to all
Redis::Store instances when multiple hosts are set.