Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for regular expression delete in Rails 3 store. #52

Closed
wants to merge 3 commits into from
Closed

Add support for regular expression delete in Rails 3 store. #52

wants to merge 3 commits into from

Conversation

tristandunn
Copy link

This is needed due to expire_fragment not calling deleted_matched unless the key is a regular expression. See https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/caching/fragments.rb#L93-97

…o their source.

This is needed due to expire_fragment not calling deleted_matched unless the key is a regular expression. See https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/caching/fragments.rb#L93-97
…*", offering greater compatibility when switching between stores.
@letronje
Copy link

Was this merged ? Why was the pull request closed ?

@tristandunn
Copy link
Author

It's almost a year old and I never received any feedback, so it was just cluttering up the pull request list. I was also initially confused, since master doesn't even contain the files I changed it seemed so old that it was absolute. I only just noticed that it would still apply to some of the branches.

@letronje
Copy link

your patch works for me locally if I modify gem source( 1.0.0.1 ). Any work-arounds or some other gem or project that I could use ?

@tristandunn
Copy link
Author

I don't even remember what I was using this for now, but honestly it probably shouldn't be merged. There are lots of other regular expression specifics that can't be converted to be compatible with Redis, so it still doesn't allow you to easily switch between stores when using a RegExp. I think if you know you're going to use Redis you should just convert to a Redis compatible string, or if you really want this just monkey patch it.

tgwizard pushed a commit to tgwizard/redis-store that referenced this pull request Jun 24, 2020
Update gemspec to remove rubyforge_project
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants