Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Query input in Explain & ExplainCli #149

Merged
merged 11 commits into from
Jun 15, 2023
Merged

Conversation

shacharPash
Copy link
Contributor

@shacharPash shacharPash commented Jun 14, 2023

Currently, Explain and ExplainCli commands accept the Query class as input. Which made it possible to insert FT.SEARCH arguments as input to those commands.
In this PR I fixed it and now the commands receive a query of type string and not of type Query.

@shacharPash shacharPash added the breakingchange API or breaking change label Jun 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09 🎉

Comparison is base (69d7896) 93.58% compared to head (f9d95d0) 93.67%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   93.58%   93.67%   +0.09%     
==========================================
  Files          78       78              
  Lines        4769     4777       +8     
  Branches      448      450       +2     
==========================================
+ Hits         4463     4475      +12     
  Misses        177      177              
+ Partials      129      125       -4     
Impacted Files Coverage Δ
src/NRedisStack/Search/Query.cs 98.15% <100.00%> (ø)
src/NRedisStack/Search/SearchCommandBuilder.cs 89.83% <100.00%> (+0.73%) ⬆️
src/NRedisStack/Search/SearchCommands.cs 100.00% <100.00%> (+1.88%) ⬆️
src/NRedisStack/Search/SearchCommandsAsync.cs 94.89% <100.00%> (+2.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@shacharPash shacharPash marked this pull request as ready for review June 15, 2023 08:15
@shacharPash shacharPash requested a review from chayim June 15, 2023 08:16
@shacharPash shacharPash requested a review from chayim June 15, 2023 10:20
@shacharPash shacharPash merged commit 7d1c314 into master Jun 15, 2023
@shacharPash shacharPash deleted the AddSearchCommands branch June 15, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants