Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CLIENT NO-EVICT #2492

Closed

Conversation

SoulPancake
Copy link
Contributor

fixes #2385

@SoulPancake SoulPancake changed the title Add support for Client No-Evict Add support for CLIENT NO-EVICT Mar 19, 2023
@SoulPancake SoulPancake marked this pull request as ready for review March 19, 2023 10:51
@SoulPancake
Copy link
Contributor Author

@monkey92t
Here's the implementation
Followed the same standard followed by Jedis.

@monkey92t
Copy link
Collaborator

client-eviction is not just a command, it is a state of the client connection, targeting a single network connection rather than the entire client.

See: https://redis.io/docs/reference/clients/

@monkey92t
Copy link
Collaborator

monkey92t commented Mar 19, 2023

This requires a complicated implementation, initially we can set it at initialization time, if we want to change during the client life cycle, we need to remember the state of each network connection.

@SoulPancake
Copy link
Contributor Author

Understood, I'll be closing this
Will understand the problem statement better to tackle this later.

@SoulPancake SoulPancake deleted the support-for-CLIENTNOEVICT branch March 29, 2023 14:01
This was referenced Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for CLIENT NO-EVICT command
2 participants