Add Redis Timeseries support #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 5, 2023
chayim
reviewed
Sep 10, 2023
chayim
previously approved these changes
Sep 11, 2023
chayim
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for RedisTimeSeries. As part of this move forward, we discovered a better naming convention for probabalistic commands - one in line with the standard library.
Proposal: this becomes part of 9.2.0, due to the breaking change.
I realize that this may be contentious - but given the relative newness of Probabilistic Filters, I'd rather not wait for v10.