Identify client on connect #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chayim
reviewed
Sep 19, 2023
chayim
reviewed
Sep 19, 2023
chayim
reviewed
Sep 19, 2023
chayim
suggested changes
Sep 19, 2023
chayim
approved these changes
Sep 19, 2023
| @@ -30,6 +30,7 @@ func NewClientStub(resp []byte) *ClientStub { | |||
| Dialer: func(ctx context.Context, network, addr string) (net.Conn, error) { | |||
| return stub.stubConn(initHello), nil | |||
| }, | |||
| DisableIndentity: true, | |||
There was a problem hiding this comment.
Is this a typo? We also need to add it to UniversalOptions. @ofekshenawa @chayim
There was a problem hiding this comment.
No, we don't want to send client setinfo on benchmark tests 😅
There was a problem hiding this comment.
I suspect the question about whether this is a typo might be because Indentity is a very uncommon word (I'm not sure it's even a generally recognised word), whereas Identity would be much more common.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2707