-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify client on connect #2708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggested DisableIndentity
but open to something obvious and shorter. Maybe DisableIdentifier?
@@ -30,6 +30,7 @@ func NewClientStub(resp []byte) *ClientStub { | |||
Dialer: func(ctx context.Context, network, addr string) (net.Conn, error) { | |||
return stub.stubConn(initHello), nil | |||
}, | |||
DisableIndentity: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo? We also need to add it to UniversalOptions. @ofekshenawa @chayim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, we don't want to send client setinfo on benchmark tests 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect the question about whether this is a typo might be because Indentity
is a very uncommon word (I'm not sure it's even a generally recognised word), whereas Identity
would be much more common.
closes #2707