Write a version file for the CMake package #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks clean to me :D. |
chayim
approved these changes
Feb 23, 2023
autoantwort
reviewed
Feb 24, 2023
CMakeLists.txt
Outdated
| @@ -154,6 +154,9 @@ else() | |||
| endif() | |||
| SET(INCLUDE_INSTALL_DIR include) | |||
| include(CMakePackageConfigHelpers) | |||
| write_basic_package_version_file("${CMAKE_CURRENT_BINARY_DIR}/hiredis-config-version.cmake" | |||
| VERSION ${VERSION} | |||
There was a problem hiding this comment.
You can even skip this line :)
> If no VERSION is given, the PROJECT_VERSION variable is used.
Since we set the project version to `${VERSION}`, we can safely skip
passing it to `write_basic_package_version_file` as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables users to ask for a specific version of hiredis via
find_package.Setting
COMPATIBILITY SameMajorVersionmeans that CMake considers newer versions as compatible as long as the major version matches, e.g., asking for1.1will succeed when finding1.2but not when finding2.0. I hope this is the desired behavior. :)CMake docs: https://cmake.org/cmake/help/v3.0/module/CMakePackageConfigHelpers.html#module:CMakePackageConfigHelpers.