-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove non-ascii colon in JedisSentintelPool #2062
Conversation
@@ -287,8 +287,8 @@ public void run() { | |||
*/ | |||
List<String> masterAddr = j.sentinelGetMasterAddrByName(masterName); | |||
if (masterAddr == null || masterAddr.size() != 2) { | |||
log.warn("Can not get master addr, master name: {}. Sentinel: {}:{}.",masterName,host,port); | |||
}else{ | |||
log.warn("Can not get master addr, master name: {}. Sentinel: {}: {}.",masterName,host,port); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you add a white space? where is none ascii?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The colon is the non ascii character here, GitHub just renders it as such. Before :
after :
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
log.warn("Can not get master addr, master name: {}. Sentinel: {}: {}.",masterName,host,port); | ||
} else{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove wrongful and/or unnecessary spaces.
@gkorland We should not merge this right now, in https://github.com/xetorthio/jedis/pull/2062/files#diff-e6525ac1a247b59a49332a6584030684R290 it changes |
@sazzad16 Ok I see your point, let's merge the other PR and close this one. |
Details about this PR can be found in #2062 .
This character will fail to compile unless compiled with the additional compiler option
-Dfile.encoding=UTF8