Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate methods with 'byte[] keyCount' param #2548

Merged
merged 2 commits into from
May 18, 2021
Merged

Deprecate methods with 'byte[] keyCount' param #2548

merged 2 commits into from
May 18, 2021

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@sazzad16 sazzad16 requested review from gkorland and dengliming and removed request for gkorland May 18, 2021 06:30
@sazzad16 sazzad16 added this to the 3.7.0 milestone May 18, 2021
@gkorland
Copy link
Contributor

@sazzad16 why do you want to deprecate these methods?

@sazzad16
Copy link
Collaborator Author

@gkorland Because these are nonsensical methods. A keyCount can be easily and should be represented by an int. There are existing methods for that purpose. So we don't need these methods anymore.

@sazzad16 sazzad16 merged commit e347ca1 into redis:master May 18, 2021
@sazzad16 sazzad16 deleted the script-keycount branch May 18, 2021 06:53
sazzad16 added a commit that referenced this pull request May 18, 2021
@sazzad16
Deprecate methods with 'byte[] keyCount' param (#2548)
3d84d8b
@chayim chayim mentioned this pull request Jun 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland approved these changes

@dengliming dengliming Awaiting requested review from dengliming

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sazzad16 @gkorland