Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(#535 with backward compatibility) Introduce *scan with "string" cursor parameter to support unsigned long cursor #536

Merged

Conversation

HeartSaVioR
Copy link
Contributor

This PR fixes #531.
It's backward compatibility version of #535, so please see #535 for details.

Changelog

  • overload all *scan method to change "int" cursor to "string" cursor
  • set @deprecated and leave reason to deprecate and when to remove to
    current *scan method
  • modify unit tests to make it work with new *scan method

cursor

* overload all *scan method to change "int" cursor to "string" cursor
* set @deprecated and leave reason to deprecate and when to remove to
current *scan method
* modify unit tests to make it work with new *scan method
@HeartSaVioR
Copy link
Contributor Author

I've prepared next action with new branches. (https://github.com/HeartSaVioR/jedis/tree/unsigned_long_cursor_remove_deprecated)

I'll propose new PR when this PR is merged to master.
Thanks!

@marcosnils marcosnils added this to the Next minor milestone Feb 9, 2014
@xetorthio
Copy link
Contributor

👍
Will be merging today as we release

@xetorthio xetorthio merged commit ed81f37 into redis:master Feb 11, 2014
@HeartSaVioR HeartSaVioR deleted the unsigned_long_cursor_with_compatibility branch March 5, 2014 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SCAN cursor is int, should be unsigned long
3 participants