Fix ACL SETUSER when adding specified categories #1839

redis · Sep 3, 2021 · 53e8272 · 53e8272
1 parent edb28c9
commit 53e8272
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/main/java/io/lettuce/core/AclSetuserArgs.java b/src/main/java/io/lettuce/core/AclSetuserArgs.java
@@ -651,7 +651,7 @@ public <K, V> void build(CommandArgs<K, V> args) {
             }
         }
 
-        if (removeCategories != null) {
+        if (addCategories != null) {
             for (AclCategory category : addCategories) {
                 args.add("+@" + category.name());
             }

diff --git a/src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java b/src/test/java/io/lettuce/core/commands/AclCommandIntegrationTests.java
@@ -116,6 +116,15 @@ void aclSetuser() {
         assertThat(redis.aclDeluser("foo")).isNotNull();
     }
 
+    @Test
+    void aclSetuserWithCategories() {
+        assertThat(redis.aclDeluser("foo")).isNotNull();
+        AclSetuserArgs args = AclSetuserArgs.Builder.on().addCategory(AclCategory.CONNECTION);
+        assertThat(redis.aclSetuser("foo", args)).isEqualTo("OK");
+        assertThat(redis.aclGetuser("foo")).contains("-@all +@connection");
+        assertThat(redis.aclDeluser("foo")).isNotNull();
+    }
+
     @Test
     void aclUsers() {
         assertThat(redis.aclUsers()).hasSize(1).first().isEqualTo("default");