Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ACL SETUSER when adding specified categories #1839

Closed
wants to merge 3 commits into from

Conversation

RohanNagar
Copy link
Contributor

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

@RohanNagar
Copy link
Contributor Author

Hi @mp911de, I was trying to run the ACL SETUSER command with added categories and found this bug in the implementation. I hope it's ok that I created this without an issue, I figured it was straightforward enough to fix and submit the patch for. Please let me know if I can do anything to help get this through the approval process and into the next release. Thank you!

@mp911de mp911de added the type: bug A general bug label Sep 2, 2021
@mp911de mp911de added this to the 6.1.5 milestone Sep 3, 2021
@mp911de
Copy link
Collaborator

mp911de commented Sep 3, 2021

Thanks a lot, that's an obvious bug, so fine having a pull request only.

@mp911de mp911de changed the title Bugfix: ACL SETUSER should add specified categories Fix ACL SETUSER when adding specified categories #1839 Sep 3, 2021
@mp911de mp911de changed the title Fix ACL SETUSER when adding specified categories #1839 Fix ACL SETUSER when adding specified categories #1839 Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Add unit tests for AclSetuserArgs.
@mp911de
Copy link
Collaborator

mp911de commented Sep 3, 2021

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 3, 2021
mp911de added a commit that referenced this pull request Sep 3, 2021
Add unit tests for AclSetuserArgs.
@RohanNagar
Copy link
Contributor Author

Thank you!

@RohanNagar RohanNagar deleted the aclsetuser-bugfix branch September 7, 2021 16:24
@mp911de mp911de changed the title Fix ACL SETUSER when adding specified categories #1839 Fix ACL SETUSER when adding specified categories Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug A general bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants