Fix cannot publish when subscribed with RESP3 #2594

Original pull request: #2778
redis · Mar 13, 2024 · a470433 · a470433
1 parent c4c6994
commit a470433
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java b/src/main/java/io/lettuce/core/protocol/DefaultEndpoint.java
@@ -814,6 +814,10 @@ protected String logPrefix() {
         return logPrefix = buffer;
     }
 
+    protected ProtocolVersion getProtocolVersion() {
+        return clientOptions.getProtocolVersion();
+    }
+
     @Override
     public String getId() {
         return cachedEndpointId;

diff --git a/src/main/java/io/lettuce/core/pubsub/PubSubEndpoint.java b/src/main/java/io/lettuce/core/pubsub/PubSubEndpoint.java
@@ -28,6 +28,7 @@
 import io.lettuce.core.RedisException;
 import io.lettuce.core.protocol.CommandType;
 import io.lettuce.core.protocol.DefaultEndpoint;
+import io.lettuce.core.protocol.ProtocolVersion;
 import io.lettuce.core.protocol.RedisCommand;
 import io.lettuce.core.resource.ClientResources;
 import io.netty.channel.Channel;
@@ -193,8 +194,8 @@ protected boolean containsViolatingCommands(Collection<? extends RedisCommand<?,
         return false;
     }
 
-    private static boolean isAllowed(RedisCommand<?, ?, ?> command) {
-        return ALLOWED_COMMANDS_SUBSCRIBED.contains(command.getType().name());
+    private boolean isAllowed(RedisCommand<?, ?, ?> command) {
+        return getProtocolVersion() == ProtocolVersion.RESP3 || ALLOWED_COMMANDS_SUBSCRIBED.contains(command.getType().name());
     }
 
     public boolean isSubscribed() {