urgent: fix for drain event

[dvv]

please, consider

[dvv]

https://github.com/dvv/node_redis/commit/9a4e51ee4011ed2fa1ac5d28e1fc6e341987a2ed is critical

https://github.com/dvv/node_redis/blob/master/index.js#L284 -- we are adding Boolean to number, then check for strict equality later at https://github.com/dvv/node_redis/blob/master/index.js#L289. Such condition never holds unless offline_queue is trivially empty. This results in drain event fire once/twice and no more.

[mranney]

I've tested this drain logic against multiple different servers and link speeds, and it worked fine. Line 284 coerces the boolean to a number by incrementing it. I'll admit this is a tad awkward, but it seems sound. Is there a case where this doesn't work?

> var a = 0
> a += !true
0
> a === 0
true

[dvv]

Sure. Please, run stress tests from my fork. If they worked, I'd never look into L284 ;)
In your examples the number of iterations too small (10000). Make it forever cycle, and things should reveal.

[mranney]

I can't reproduce the failure, but the falsiness test is more consistent, so we might as well do that.

Thanks for looking into this.

[mranney]

Pushed v0.6.5 with your change.