DOC-3914: re-issue TCE PRs previously issued by justincastilla #2781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpotter
reviewed
Jul 3, 2024
| // REMOVE_END | ||
|
|
||
| // STEP_START xRange | ||
| const res4 = await client.xRange('race:france', '1691765278160-0', '+', 2); |
There was a problem hiding this comment.
I feel a bit skeptical about these. How can ranges work for streams when added with a '*' style IDs that would be based on timestamp work consistently (throughout this example). Maybe I'm missing something?
There was a problem hiding this comment.
I don't know the streams data type well enough to comment intelligently, but the same examples are present for the other 3 client libraries. The person who created the initial CLI examples is long gone from Redis.
There was a problem hiding this comment.
ok. I'll investigate a bit more, just feels weird to me, as I said, it might just be my lack of experience with them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains doctests previously written by justincastilla that are to be used on the docs site as tabbed code examples. There were issues with the previous PRs which I could not resolve, not having the permissions to do so. @dmaier-redislabs suggested I issue a new PR that contains edited versions of those PRs.
Checklist
npm testpass with this change (including linting)?