Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passing filter format down Fixes #438 #439

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

slorello89
Copy link
Member

Need to make sure that filter formatting is passed down recursively when splitting binary expressions to ensure that strings are properly formatted for filter expressions in aggregations.

Copy link

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 LGTM!

@slorello89 slorello89 merged commit cd8919a into main Apr 12, 2024
1 check failed
slorello89 added a commit that referenced this pull request Jun 6, 2024
passing filter format down
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badly formatted filter expression on AggreagtionSet
2 participants