Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update models.md #573

Merged
merged 1 commit into from
May 7, 2024
Merged

Update models.md #573

merged 1 commit into from
May 7, 2024

Conversation

shobu13
Copy link
Contributor

@shobu13 shobu13 commented Oct 24, 2023

reference:
model.model (1251)

        if not getattr(new_class._meta, "model_key_prefix", None):
            # Don't look at the base class for this.
            new_class._meta.model_key_prefix = (
                f"{new_class.__module__}.{new_class.__name__}"
            )

so the property default to the module name + class name instead of just "", current documentation may missleadv :)

reference:
model.model (1251)
```python
        if not getattr(new_class._meta, "model_key_prefix", None):
            # Don't look at the base class for this.
            new_class._meta.model_key_prefix = (
                f"{new_class.__module__}.{new_class.__name__}"
            )
```

so the property default to the module name + class name instead of just "", current documentation may missleadv :)
Copy link

@bsbodden bsbodden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slorello89 slorello89 added the documentation Improvements or additions to documentation label May 7, 2024
Copy link
Member

@slorello89 slorello89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@slorello89 slorello89 merged commit 52d1f88 into redis:main May 7, 2024
@shobu13 shobu13 deleted the patch-1 branch August 2, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants