Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support timeout = 0 in search query (#2934)
* Support query timeout = 0 In RediSearch query timeout = 0 means unlimited timeout. In the current implementation, the query timeout is only updated `if timeout` which in case of 0, translates to false. Since the default timeout of the `query` class is None, replacing the condition with `if self._timeout is not None` will also work for 0. If the parameter is not a positive integer, redis server will raise an exception. related issue: #2928 #2839 * added a test to quety.timeout(0) * raise an exception if query TIMEOUT is a non negative integer * fixed the query test to catach AttributeError * Moved validating timeout to timeout() Raise the exception when the timeout is set instead of when the query is performed * updates test to catch the exception when query.timeout() is called * Update redis/commands/search/query.py Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com> * Revert "Update redis/commands/search/query.py" This reverts commit fb2b710. * Revert "updates test to catch the exception when query.timeout() is called" This reverts commit 6590130. * Revert "Moved validating timeout to timeout()" This reverts commit 7a020bd. * Revert "fixed the query test to catach AttributeError" This reverts commit 25d4ddf. * Revert "raise an exception if query TIMEOUT is a non negative integer" This reverts commit 3fb2c68. --------- Co-authored-by: GuyAv46 <47632673+GuyAv46@users.noreply.github.com>
- Loading branch information