Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for redis 7 commands #1813

Closed
56 tasks done
chayim opened this issue Dec 16, 2021 · 3 comments
Closed
56 tasks done

Add Support for redis 7 commands #1813

chayim opened this issue Dec 16, 2021 · 3 comments
Labels
redis-7 tracking-issue An issue container, effectively an epic

Comments

@chayim
Copy link
Contributor

chayim commented Dec 16, 2021

As part of the upcoming Redis 7 release, at least the following commands should be implemented. As part of this tracking, we'll also need to start a redis 7 docker, and integrate it into tox. For commands that will not be implemented in the client - we want to define a function, and raise a NotImplementedError (like others!), ensuring the documentation states that this is the behaviour.

@chayim chayim added the tracking-issue An issue container, effectively an epic label Dec 16, 2021
@chayim chayim assigned dvora-h and unassigned dvora-h Dec 16, 2021
@madolson
Copy link

There will be new publish commands, per (https://github.com/redis/redis/pull/8621/files). Mentioning this because the logic for pubsub will also be changed a little bit for cluster mode. There is logic that sets the "first" key from a command ,

elif command in ["SUBSCRIBE", "PSUBSCRIBE", "UNSUBSCRIBE", "PUNSUBSCRIBE"]:
, that explicitly looks for a pubsub flag + the name, this will cause the new commands to return NULL.

@Andrew-Chen-Wang
Copy link
Contributor

Andrew-Chen-Wang commented Jan 5, 2022

Is it possible for there to be a change in ownership of aioredis to RedisLab or for Redis employees to make parallel PRs to aioredis? All these commands only need a simple async/await combination. Aioredis is vital to the asyncio Python community like FastAPI and Django channels, and I can't keep up with a paid staff, especially during school.

@madolson
Copy link

@Andrew-Chen-Wang I'm not from Redis Ltd, but perhaps it might make sense to merge in the async functionality into the main repo instead of maintaining a fork? Would that be a lot of work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
redis-7 tracking-issue An issue container, effectively an epic
Projects
None yet
Development

No branches or pull requests

4 participants