Added dynamic_startup_nodes configuration to RedisCluster. #2244
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Added dynamic_startup_nodes configuration to RedisCluster.
By default, when reinitializing the cluster topology, the nodesManager will use only the initial passed startup nodes to refresh the cluster topology. If dynamic_startup_nodes is set to true, the nodesManager will set the startup nodes to all of the discovered nodes and they will be used to determine the cluster nodes-slots mapping in the next topology refresh.
When true, the initial passed startup nodes will be removed if their endpoints aren't listed in the CLUSTER SLOTS output. For example, if dynamic DNS endpoints are used for startup nodes, but CLUSTER SLOTS lists specific IP addresses, the passed startup nodes will be overridden with the specific nodes' IP.
Therefore, it is recommended to keep dynamic_startup_nodes set to false with DNS endpoints.