-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mishandles encodings that are not a superset of ascii #430
Comments
p
added a commit
to p-push/redis-dump-load
that referenced
this issue
Jan 27, 2014
See also redis/redis-py#430 for the same issue in redis-py.
p
added a commit
to p-push/redis-dump-load
that referenced
this issue
Jan 27, 2014
…n that situation. See redis/redis-py#430 for the issue.
p
added a commit
to p-push/redis-dump-load
that referenced
this issue
Jan 27, 2014
…n that situation. See redis/redis-py#430 for the issue.
Looks like this is isolated to Python 3. I suspect that you're on the right track -- the entire command string gets encoded rather than just the user supplied data. |
Yes, python 2 works. |
@p I just pushed a fix for this. If you have a few minutes to look at it/test it in your setup I'd really appreciate it. Let me know what you find! |
p
added a commit
to p/redis-dump-load
that referenced
this issue
Apr 26, 2015
@andymccurdy the fix works, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
redis-py 2.9.1:
It looks like redis encodes command itself using the configured encoding, but encoding should only apply to user data (keys/values).
The text was updated successfully, but these errors were encountered: