Add an Event parameter to PubSubWorkerThread and run_in_thread so #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that the PubSubWorkerThread can be reliably stopped. The existing mechanism is left in place so that there is no API change.
Codecov Report
@@ Coverage Diff @@
## master #1195 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 20 20
Lines 5669 5669
=======================================
Hits 5238 5238
Misses 431 431
Continue to review full report at Codecov.
|
just using the Event() rather than a Bool. Tested out OK.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
that the PubSubWorkerThread can be reliably stopped.
The existing mechanism is left in place so that there is no API change.
Pull Request check-list
Please make sure to review and check all of these items:
$ python setup.py testpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please let me know what you think of the change. If I should make any other adjustments or tests. I don't mind to rework the Class and API further, but did not want introduce any significant changes.
#1194