Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Includes slowlog complexity info if available #1489

Merged
merged 4 commits into from
Aug 29, 2021

Conversation

ian28223
Copy link
Contributor

@ian28223 ian28223 commented Jun 2, 2021

Pull Request check-list

  • Does $ tox pass with this change (including linting)?
  • Does travis tests pass with this change (enable it first in your forked repo and wait for the travis build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Includes complexity info from item[3] if command is in item[4]

Based on #622
tests copied from above PR

@codecov-commenter
Copy link

Codecov Report

Merging #1489 (f904b47) into master (bc58542) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1489      +/-   ##
==========================================
+ Coverage   86.58%   86.61%   +0.03%     
==========================================
  Files           7        7              
  Lines        2914     2921       +7     
==========================================
+ Hits         2523     2530       +7     
  Misses        391      391              
Impacted Files Coverage Δ
redis/client.py 87.07% <100.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc58542...f904b47. Read the comment docs.

@ian28223
Copy link
Contributor Author

@andymccurdy Sorry for tagging you here but I couldn't find anyone else to review

@chayim chayim self-requested a review July 22, 2021 15:53
@chayim
Copy link
Contributor

chayim commented Jul 22, 2021

@andymccurdy Sorry for tagging you here but I couldn't find anyone else to review

@ian28223 I assigned it to myself to have a look. I'll likely do so Sunday.

@chayim
Copy link
Contributor

chayim commented Aug 29, 2021

@ian28223 Thanks a tonne for this contribution! It looks like a great addition to redis-py support for Redis Enterprise. For curious future readers here are some docs.

@chayim chayim merged commit 41e3f56 into redis:master Aug 29, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
Includes slowlog complexity info if available (redis/redis-py#1489)

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants