changing unit tests to account for defaults in redis flags #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some versions of redis (validated against 6.2.4) set extra flags, making the tests fail. Modified the tests to validate the specific flags pertaining to the test case are in place. Similarly with acl_list, as other tests validate the specifics of acl_setuser, I changed it to validate against the acl list. Finally, while here, I added python 3.9 to tox
This was referenced Jul 14, 2021
|
Just a note: I am a big friend of the method |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Jul 18, 2021
https://build.opensuse.org/request/show/906638 by user mcepl + dimstar_suse - Add account-defaults-redis.patch which fixes failing tests by taking into consideration redis defaults, not overwriting them (gh#redis/redis-py#1499).
Andrew-Chen-Wang
added a commit
to aio-libs-abandoned/aioredis-py
that referenced
this pull request
Oct 8, 2021
changing unit tests to account for defaults in redis flags redis/redis-py#1499 * This does not include the changes in tests/test_pubsub.py because we do not implement threading. Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Please make sure to review and check all of these items:
$ toxpass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Some versions of redis (validated against 6.2.4) set extra flags, making the tests fail.
Modified the tests to validate the specific flags pertaining to the test case are in place.
Similarly with acl_list, as other tests validate the specifics of acl_setuser, I changed it to validate against the acl list.
Finally, while here, I added python 3.9 to tox.
closes #1459
closes #1478