Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-reconnect PubSub on get_message #1574

Merged
merged 1 commit into from
Sep 30, 2021
Merged

Auto-reconnect PubSub on get_message #1574

merged 1 commit into from
Sep 30, 2021

Conversation

luhn
Copy link
Contributor

@luhn luhn commented Sep 10, 2021 •
edited

Wraps conn.can_read() in _execute(), so that a connection error is properly handled.

Fixes #1572.

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested? I don't think a new test is necessary
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)? N/A

@chayim chayim merged commit bfc4cd9 into redis:master Sep 30, 2021
Andrew-Chen-Wang added a commit to aio-libs-abandoned/aioredis-py that referenced this pull request Oct 8, 2021
@Andrew-Chen-Wang
Add redis/redis-py@bfc4cd9
a5bb394 
Auto-reconnect PubSub on get_message (redis/redis-py#1574)

* Thank you Theron Luhn <@luhn>!!!
* Fixes #1130

Signed-off-by: Andrew-Chen-Wang <acwangpython@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PubSub does not auto-reconnect with get_message()
2 participants
@luhn @chayim