Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to allow --redis-url to pass through all tests #1700

Merged
merged 9 commits into from
Nov 11, 2021
Merged

Conversation

chayim
Copy link
Contributor

@chayim chayim commented Nov 11, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Nov 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2021

Codecov Report

Merging #1700 (18d0fd8) into master (ec172e7) will decrease coverage by 3.09%.
The diff coverage is 82.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1700      +/-   ##
==========================================
- Coverage   92.21%   89.12%   -3.10%     
==========================================
  Files          53       53              
  Lines       11009    11067      +58     
==========================================
- Hits        10152     9863     -289     
- Misses        857     1204     +347     
Impacted Files Coverage Δ
tests/test_monitor.py 74.50% <44.44%> (-25.50%) ⬇️
tests/test_commands.py 93.54% <82.35%> (-6.27%) ⬇️
tests/conftest.py 94.19% <84.61%> (+0.53%) ⬆️
tests/test_connection_pool.py 94.35% <100.00%> (-5.65%) ⬇️
tests/test_pubsub.py 97.62% <100.00%> (-2.12%) ⬇️
tests/test_scripting.py 100.00% <100.00%> (ø)
redis/commands/core.py 83.85% <0.00%> (-6.21%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec172e7...18d0fd8. Read the comment docs.

@chayim chayim merged commit 6a293e6 into master Nov 11, 2021
@chayim chayim deleted the ck-testfixes branch November 11, 2021 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants