Fixing deprecating distutils (PEP 632)

[chayim]

Pull Request check-list

Please make sure to review and check all of these items:

• Does $ tox pass with this change (including linting)?
• Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
• Is the new or changed code fully tested?
• Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

fixes #1729

[codecov-commenter]

Codecov Report

Merging #1730 (1dbade7) into master (f4519f3) will increase coverage by 28.46%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master    #1730       +/-   ##
===========================================
+ Coverage   62.34%   90.80%   +28.46%     
===========================================
  Files          59       59               
  Lines       14249    14249               
===========================================
+ Hits         8883    12939     +4056     
+ Misses       5366     1310     -4056     

Impacted Files	Coverage Δ
setup.py	0.00% <ø> (ø)
redis/connection.py	71.89% <100.00%> (+1.42%)	⬆️
tests/test_cluster.py	98.60% <0.00%> (ø)
redis/commands/sentinel.py	64.28% <0.00%> (+10.71%)	⬆️
tests/test_pubsub.py	97.68% <0.00%> (+11.34%)	⬆️
redis/commands/core.py	84.00% <0.00%> (+11.40%)	⬆️
tests/test_commands.py	93.47% <0.00%> (+20.70%)	⬆️
redis/client.py	83.31% <0.00%> (+20.85%)	⬆️
redis/commands/json/path.py	100.00% <0.00%> (+22.22%)	⬆️
... and 32 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4519f3...1dbade7. Read the comment docs.

[elderlabs]

Would there be any benefit to using setuptools version comparison implementation, as many projects already require it to install other deps, instead of adding packaging as a requirement for this sole purpose?

[chayim]

I thought about it - as I definitely prefer to not have any dependencies (in fact, I intend to remove the deprecation dep in the future) for this type of library. There are two issues here:

1. PEP 632 specifically refers to packaging (find, we can ignore this)
2. Setuptools version comparison is broken for our needs- in that it fails to parse the third period (part of PEP-0440)

Here's an example of #2

from pkg_resources import parse_version as V
v456 = V('4.5.6')
v457prev = V('4.5.7preview')
v457prev2 = V('4.5.7.preview')
v457 = V('4.5.7')

v457prev > v456
>>> True

v457 > v456
>>> True

v457prev2 > v456
>>> False