Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding connection class via keyword arguments #1752

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

m-novikov
Copy link
Contributor

@m-novikov m-novikov commented Nov 26, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

This allows overriding the connection class which is implicitly guessed by the schema provided in the URI.
While other arguments parsed from URI have precedence, current behavior is inconsistent, user can override class for default redis:// but not rediss:// and unix://.
Closes: #1739

@chayim
Copy link
Contributor

chayim commented Dec 2, 2021

@m-novikov Thank you for the contribution! We'll merge it in, and this will release with the upcoming release candidate.

@chayim chayim merged commit d4a9825 into redis:master Dec 2, 2021
@m-novikov m-novikov deleted the m-novikov-connection-class-override branch December 2, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom connection class overriden by redis uri
2 participants