Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrated targeted nodes to kwargs in Cluster Mode #1762

Merged
merged 10 commits into from
Dec 1, 2021

Conversation

barshaul
Copy link
Contributor

@barshaul barshaul commented Dec 1, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Added **kwargs to Redis' non key-based commands so they could be reused with target_nodes key word in RedisCluster. Removed duplicated commands from commands/cluster.py.

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021

Codecov Report

Merging #1762 (4175251) into master (175a05f) will increase coverage by 2.38%.
The diff coverage is 92.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
+ Coverage   90.86%   93.25%   +2.38%     
==========================================
  Files          70       70              
  Lines       15185    15072     -113     
==========================================
+ Hits        13798    14055     +257     
+ Misses       1387     1017     -370     
Impacted Files Coverage Δ
redis/commands/cluster.py 94.82% <78.57%> (+9.01%) ⬆️
redis/cluster.py 89.73% <83.33%> (-0.13%) ⬇️
tests/conftest.py 91.87% <88.88%> (+0.04%) ⬆️
redis/commands/core.py 90.05% <89.86%> (+6.04%) ⬆️
redis/client.py 89.84% <100.00%> (+5.03%) ⬆️
redis/commands/__init__.py 100.00% <100.00%> (ø)
tests/test_cluster.py 98.66% <100.00%> (+0.06%) ⬆️
tests/test_commands.py 99.38% <100.00%> (+5.90%) ⬆️
tests/test_connection_pool.py 100.00% <100.00%> (+5.58%) ⬆️
tests/test_monitor.py 90.56% <100.00%> (+15.09%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175a05f...4175251. Read the comment docs.

@barshaul barshaul marked this pull request as ready for review December 1, 2021 14:53
@chayim chayim added 4.1.0 breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc) labels Dec 1, 2021
@chayim chayim changed the title Added **kwargs to Redis' core non key-based commands to reuse with Cluster Mode Migrated targeted nodes to kwargs in Cluster Mode Dec 1, 2021
@chayim chayim merged commit d425227 into redis:master Dec 1, 2021
@chayim chayim deleted the target_nodes branch December 1, 2021 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakingchange API or Breaking Change maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants