-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection examples #1835
Connection examples #1835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1835 +/- ##
==========================================
- Coverage 94.33% 93.63% -0.71%
==========================================
Files 75 76 +1
Lines 15830 16207 +377
==========================================
+ Hits 14934 15175 +241
- Misses 896 1032 +136
Continue to review full report at Codecov.
|
Can you add more examples of URL functions - specifying ports, etc? See Line 850 of client.py and how to calls ConnectionPool. Similarly can you add some cluster examples... Also sentinel. See the README. CC @barshaul |
Pull Request check-list
Please make sure to review and check all of these items:
$ tox
pass with this change (including linting)?NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.
Create connection example notebook #1786