Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection examples #1835

Merged
merged 6 commits into from
Dec 30, 2021
Merged

Connection examples #1835

merged 6 commits into from
Dec 30, 2021

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Dec 27, 2021

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.
Create connection example notebook #1786

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #1835 (708d8d9) into master (271218e) will decrease coverage by 0.70%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
- Coverage   94.33%   93.63%   -0.71%     
==========================================
  Files          75       76       +1     
  Lines       15830    16207     +377     
==========================================
+ Hits        14934    15175     +241     
- Misses        896     1032     +136     
Impacted Files Coverage Δ
tests/test_ssl.py 54.12% <0.00%> (-37.54%) ⬇️
redis/__init__.py 80.95% <0.00%> (-9.53%) ⬇️
redis/utils.py 88.88% <0.00%> (-1.44%) ⬇️
tests/conftest.py 89.76% <0.00%> (-1.37%) ⬇️
redis/client.py 89.37% <0.00%> (-0.59%) ⬇️
redis/connection.py 88.33% <0.00%> (-0.38%) ⬇️
redis/commands/core.py 89.93% <0.00%> (-0.16%) ⬇️
tests/test_cluster.py 98.79% <0.00%> (-0.01%) ⬇️
redis/retry.py 100.00% <0.00%> (ø)
tests/test_json.py 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271218e...708d8d9. Read the comment docs.

redis/client.py Outdated Show resolved Hide resolved
@chayim
Copy link
Contributor

chayim commented Dec 28, 2021

Can you add more examples of URL functions - specifying ports, etc? See Line 850 of client.py and how to calls ConnectionPool. Similarly can you add some cluster examples... Also sentinel. See the README.

CC @barshaul

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Dec 30, 2021
@chayim chayim changed the title Connection example Connection examples Dec 30, 2021
@chayim chayim merged commit deaaa53 into redis:master Dec 30, 2021
@chayim chayim mentioned this pull request Dec 30, 2021
@dvora-h dvora-h deleted the connection-example branch January 3, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants