Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FT.CREATE - support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, SKIPINITIALSCAN #1847

Merged
merged 19 commits into from
Jan 10, 2022

Conversation

AvitalFineRedis
Copy link
Contributor

@AvitalFineRedis AvitalFineRedis commented Jan 3, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Based on RediSearch/redisearch-py#144

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2022

Codecov Report

Merging #1847 (abdd9d3) into master (231d402) will increase coverage by 0.01%.
The diff coverage is 98.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   93.64%   93.65%   +0.01%     
==========================================
  Files          76       76              
  Lines       16207    16269      +62     
==========================================
+ Hits        15177    15237      +60     
- Misses       1030     1032       +2     
Impacted Files Coverage Δ
redis/commands/search/commands.py 89.07% <93.75%> (+0.61%) ⬆️
tests/test_search.py 99.07% <100.00%> (+0.05%) ⬆️
tests/conftest.py 89.76% <0.00%> (-0.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 231d402...abdd9d3. Read the comment docs.

@AvitalFineRedis
Copy link
Contributor Author

@chayim Ready to merge

@chayim chayim added the feature New feature label Jan 10, 2022
@chayim chayim merged commit cb19873 into redis:master Jan 10, 2022
@AvitalFineRedis AvitalFineRedis deleted the ft.create_labels branch January 10, 2022 08:26
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 11, 2022
…IALSCAN (redis#1847)

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
…IALSCAN (redis#1847)

Co-authored-by: Chayim I. Kirshen <c@kirshen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support MAXTEXTFIELDS, TEMPORARY, NOHL, NOFREQS, SKIPINITIALSCAN in FT.CREATE
3 participants