Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SINTERCARD #1859

Merged
merged 3 commits into from
Feb 2, 2022
Merged

Add support for SINTERCARD #1859

merged 3 commits into from
Feb 2, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 5, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1808

@dvora-h dvora-h added feature New feature redis-7 labels Jan 5, 2022
@dvora-h dvora-h requested a review from chayim January 5, 2022 10:59
@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1859 (5ad88f5) into master (15f315a) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1859      +/-   ##
==========================================
+ Coverage   93.60%   93.63%   +0.03%     
==========================================
  Files          76       76              
  Lines       16214    16225      +11     
==========================================
+ Hits        15177    15193      +16     
+ Misses       1037     1032       -5     
Impacted Files Coverage Δ
redis/commands/core.py 89.96% <100.00%> (+0.02%) ⬆️
tests/test_commands.py 99.39% <100.00%> (+<0.01%) ⬆️
tests/test_cluster.py 98.66% <0.00%> (+0.12%) ⬆️
tests/conftest.py 90.99% <0.00%> (+1.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 15f315a...5ad88f5. Read the comment docs.


For more information check https://redis.io/commands/sintercard
"""
args = [numkeys] + keys + ["LIMIT", limit]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

args = [numkeys, *x, "LIMIT", limit]

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WDYT about the args change?

@dvora-h dvora-h requested a review from chayim January 13, 2022 12:39
@dvora-h dvora-h merged commit b541da6 into redis:master Feb 2, 2022
@dvora-h dvora-h deleted the add-sintercard branch February 2, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SINTERCARD
3 participants