Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PEXPIRETIME #1861

Merged
merged 3 commits into from
Mar 6, 2022
Merged

Add support for PEXPIRETIME #1861

merged 3 commits into from
Mar 6, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 5, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

closes #1807

@dvora-h dvora-h added feature New feature redis-7 labels Jan 5, 2022
@dvora-h dvora-h requested a review from chayim January 5, 2022 11:01
@codecov-commenter
Copy link

codecov-commenter commented Mar 6, 2022

Codecov Report

Merging #1861 (cb5c965) into master (c4e4088) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1861      +/-   ##
==========================================
- Coverage   92.21%   92.18%   -0.03%     
==========================================
  Files         100      100              
  Lines       20978    20991      +13     
==========================================
+ Hits        19344    19351       +7     
- Misses       1634     1640       +6     
Impacted Files Coverage Δ
tests/test_commands.py 99.10% <40.00%> (-0.18%) ⬇️
redis/commands/core.py 85.90% <100.00%> (-0.09%) ⬇️
tests/test_cluster.py 98.29% <0.00%> (ø)
redis/asyncio/connection.py 82.77% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4e4088...cb5c965. Read the comment docs.

@dvora-h dvora-h merged commit 1f2259f into redis:master Mar 6, 2022
@dvora-h dvora-h deleted the add-pexpiretime branch March 10, 2022 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for PEXPIRETIME
3 participants