Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple quote docstrings in client.py PEP 257 #1876

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Andrew-Chen-Wang
Copy link
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #1876 (56314fc) into master (41cef47) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1876      +/-   ##
==========================================
+ Coverage   93.60%   93.63%   +0.02%     
==========================================
  Files          76       76              
  Lines       16268    16268              
==========================================
+ Hits        15228    15232       +4     
+ Misses       1040     1036       -4     
Impacted Files Coverage Δ
redis/client.py 89.37% <ø> (ø)
tests/test_cluster.py 98.41% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41cef47...56314fc. Read the comment docs.

@chayim chayim added the maintenance Maintenance (CI, Releases, etc) label Jan 12, 2022
@chayim
Copy link
Contributor

chayim commented Jan 12, 2022

Thanks @Andrew-Chen-Wang . Fantastic! These things really improve the project.

This got me thinking, I found a flake8 plugin that I think could be helpful here.

@chayim chayim merged commit f807f3b into redis:master Jan 12, 2022
@Andrew-Chen-Wang Andrew-Chen-Wang deleted the patch-5 branch January 12, 2022 14:12
dvora-h pushed a commit to dvora-h/redis-py that referenced this pull request Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Maintenance (CI, Releases, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants