Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw NotImplementedError for HELLO #1912

Merged
merged 7 commits into from
Feb 6, 2022
Merged

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 30, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim January 30, 2022 03:09
@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #1912 (c1c5eec) into master (f9d8091) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1912   +/-   ##
=======================================
  Coverage   93.03%   93.03%           
=======================================
  Files          76       76           
  Lines       16567    16573    +6     
=======================================
+ Hits        15413    15419    +6     
  Misses       1154     1154           
Impacted Files Coverage Δ
redis/commands/core.py 90.26% <100.00%> (+0.01%) ⬆️
tests/test_commands.py 99.40% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9d8091...c1c5eec. Read the comment docs.

@dvora-h dvora-h requested a review from chayim February 3, 2022 10:46
redis/commands/core.py Outdated Show resolved Hide resolved
@dvora-h dvora-h merged commit ba3134c into redis:master Feb 6, 2022
@dvora-h dvora-h deleted the unsupported-hello branch February 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants