Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set and get examples #1916

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Add set and get examples #1916

merged 2 commits into from
Feb 6, 2022

Conversation

dogukanteber
Copy link
Contributor

This PR partly resolves #1744. I have added simple get and set examples according to this comment

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2022

Codecov Report

Merging #1916 (49cbfdb) into master (1ea842c) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   92.97%   92.95%   -0.03%     
==========================================
  Files          76       76              
  Lines       16441    16441              
==========================================
- Hits        15286    15282       -4     
- Misses       1155     1159       +4     
Impacted Files Coverage Δ
tests/conftest.py 88.73% <0.00%> (-0.91%) ⬇️
tests/test_cluster.py 98.28% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ea842c...49cbfdb. Read the comment docs.

@chayim
Copy link
Contributor

chayim commented Jan 31, 2022

@dogukanteber This is great - exactly the sorts of things we were discussing in the PR. What do you think about adding the link to the examples.rst in the docs folder? Can I trouble you to connect the dots. After that, we'll merge right in!.

@dogukanteber
Copy link
Contributor Author

dogukanteber commented Jan 31, 2022

Oh, I completely forgot about that part @chayim. I linked the file to example.rst. Even though I can see the generated file in my browser, I have no idea why I am failing in unit tests. Do you have any idea?

@chayim
Copy link
Contributor

chayim commented Feb 2, 2022

@dogukanteber This is perfect! Unit tests are failing due to an upstream docker issue that I need to fix. This is solidly approved - I'll merge once I have that docker fixed. So excited!!!!

@chayim chayim self-requested a review February 2, 2022 12:22
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - needs the same redismod upstream docker fix as other PRs. This is on me.

@chayim chayim merged commit 9b99bf9 into redis:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We need examples!
3 participants