Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints for hash commands #1919

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Add type hints for hash commands #1919

merged 4 commits into from
Feb 3, 2022

Conversation

dvora-h
Copy link
Collaborator

@dvora-h dvora-h commented Jan 31, 2022

Pull Request check-list

Please make sure to review and check all of these items:

  • Does $ tox pass with this change (including linting)?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

@dvora-h dvora-h requested a review from chayim January 31, 2022 10:49
@dvora-h dvora-h added the feature New feature label Jan 31, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1919 (adc44ee) into master (8499adc) will decrease coverage by 33.82%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1919       +/-   ##
===========================================
- Coverage   92.96%   59.13%   -33.83%     
===========================================
  Files          76       76               
  Lines       16441    15780      -661     
===========================================
- Hits        15284     9332     -5952     
- Misses       1157     6448     +5291     
Impacted Files Coverage Δ
redis/commands/core.py 84.36% <100.00%> (-5.56%) ⬇️
redis/commands/timeseries/utils.py 0.00% <0.00%> (-100.00%) ⬇️
redis/commands/timeseries/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
redis/commands/timeseries/commands.py 0.00% <0.00%> (-99.50%) ⬇️
redis/commands/timeseries/info.py 0.00% <0.00%> (-91.43%) ⬇️
tests/test_bloom.py 10.94% <0.00%> (-88.60%) ⬇️
tests/test_json.py 11.91% <0.00%> (-88.09%) ⬇️
tests/test_search.py 11.07% <0.00%> (-88.01%) ⬇️
tests/test_timeseries.py 12.75% <0.00%> (-87.25%) ⬇️
tests/test_graph_utils/test_path.py 11.29% <0.00%> (-87.22%) ⬇️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8499adc...adc44ee. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as others - needs redismod fix.

@dvora-h dvora-h merged commit ee078bf into redis:master Feb 3, 2022
@dvora-h dvora-h deleted the hash-t-h branch February 3, 2022 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants